Neil Hopcroft

A digital misfit

Octave build break – build 298

The Octave build has broken during “make check” because of a missing file: test/test/fntest.m
The most likely candidate for causing this problem is changeset 20308:bacaec9b5535

eliminate recursive make invocation in test directory tree
* test/module.mk: New file created from test/Makefile.am, test/bug-35448/module.mk, test/bug-36025/module.mk, test/bug-38236/module.mk, test/bug-38691/module.mk, test/bug-44940/module.mk, test/class-concat/module.mk, test/classdef/module.mk, test/classes/module.mk, test/ctor-vs-method/module.mk, test/fcn-handle-derived-resolution/module.mk, and test/nest/module.mk.
* test/Makefile.am, test/bug-35448/module.mk, test/bug-36025/module.mk, test/bug-38236/module.mk, test/bug-38691/module.mk, test/bug-44940/module.mk, test/class-concat/module.mk, test/classdef/module.mk, test/classes/module.mk, test/ctor-vs-method/module.mk, test/fcn-handle-derived-resolution/module.mk, test/nest/module.mk: Delete.
* configure.ac (AC_OUTPUT): Don’t generate test/Makefile.
* Makefile.am: Include test/module.mk.
* build-aux/common.mk, test/build-bc-overload-tests.sh: Adapt to changes in Makefile structure.

I have made a crude patch in build 304 for the Makefile which has taken a copy of the Makefile as currently created and manually edited to remove the extra test/ in the check-local target. This patch is fragile, in that it will clobber any changes to the build in stages “make check” and later. A better way would be to patch using a regex to adjust Makefile.in, but it works for the moment.
This change makes the readability of the test results worse, but the results appear more-or-less the same, there is one extra test passing now that was failing before.


Leave a Reply

Your email address will not be published.